Skip to content

Add presignHeadObjec method to S3Presigner#5476

Closed
tmccombs wants to merge 2 commits into
aws:masterfrom
tmccombs:presign-head-object
Closed

Add presignHeadObjec method to S3Presigner#5476
tmccombs wants to merge 2 commits into
aws:masterfrom
tmccombs:presign-head-object

Conversation

@tmccombs
Copy link
Copy Markdown

@tmccombs tmccombs commented Aug 6, 2024 •
edited
Loading

So that you can sign HEAD requests to S3.

Fixes #5473
Fixes #5276

Motivation and Context

Provide a way to create signed urls for HEAD requests to s3

Modifications

Add a presignHeadObject method to S3Presigner

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@rhollander73
Copy link
Copy Markdown

rhollander73 commented Feb 3, 2025

I needed this feature so I used this feature branch to see if it works. But I had to make more code changes to it to make it work.
image

@tmccombs
Copy link
Copy Markdown
Author

tmccombs commented Feb 3, 2025

@rhollander73 would you mind pushing up your changes, or sending a diff?

@tmccombs
Copy link
Copy Markdown
Author

tmccombs commented Feb 3, 2025

@debora-ito Is this something worth finishing? Or is it unlikely to get merged?

@rhollander73
Copy link
Copy Markdown

rhollander73 commented Feb 5, 2025

presigned-head-object.patch
I have created a patch in IntelliJ. I cannot push my changes to this feature branch or create a new branch from this feature branch and push my changes to it.

@rhollander73
Copy link
Copy Markdown

rhollander73 commented Feb 6, 2025

@tmccombs I did sent an IntelliJ patch in the previous comment. Are you able to install this patch?

@tmccombs
Add presignHeadObjec method to S3Presigner
18d7168 
So that you can sign HEAD requests to S3.

Fixes  aws#5473
@tmccombs tmccombs force-pushed the presign-head-object branch from 3690deb to 18d7168 Compare February 7, 2025 00:57
@tmccombs
Copy link
Copy Markdown
Author

tmccombs commented Feb 7, 2025

I've incorporated your patch into my branch

@tmccombs tmccombs marked this pull request as ready for review May 8, 2025 21:42
@tmccombs tmccombs requested a review from a team as a code owner May 8, 2025 21:42
@RanVaknin RanVaknin mentioned this pull request Jun 4, 2025
Merged
@RanVaknin
Copy link
Copy Markdown
Contributor

RanVaknin commented Jun 4, 2025

Hi @tmccombs

Thanks for raising the PR. Since this PR is about a year old I took the liberty of raising a new one with your changes, and additional support for HeadBucket as well and test coverage that was missing.
I added attribution in the changelog so it would reflect the work you've already done.

Thanks again for your help!
Ran~

@RanVaknin RanVaknin closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support HEAD requests for S3Presigner S3 Presign Head method

3 participants

@tmccombs @rhollander73 @RanVaknin